Is cross-selling good or bad?

Its good. It is essentially a very successful business strategy that is the essence of selling one product and selling another product that makes it better or improves its value. "Have a cookie? Here have some milk with that."

If it is done well such as the milk and cookie reference, then it is not only encouraged but accepted as a decent marketing strategy.